-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(textarea): 修复 slot 嵌套使用 textarea 时的输入失焦问题 #3084
Conversation
Walkthrough此次修改主要集中在 Changes
Warning Review ran into problemsProblems (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v4 #3084 +/- ##
==========================================
- Coverage 83.98% 83.96% -0.03%
==========================================
Files 226 226
Lines 22939 22939
Branches 2479 2475 -4
==========================================
- Hits 19266 19260 -6
- Misses 3655 3661 +6
Partials 18 18 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- src/packages/__VUE/textarea/textarea.taro.vue (1 hunks)
Files skipped from review due to trivial changes (1)
- src/packages/__VUE/textarea/textarea.taro.vue
这个 PR 做了什么? (简要描述所做更改)
场景:textarea 的使用层级较深(即被多层组件包裹使用)时,输入会触发失去焦点,导致无法连续输入
代码:当 autofoucs 设置为 false 时,上述场景会被触发
解决办法:当 autofocus 为 true 时设置属性,否则不设置
历史提交:
810cb85
#2123
关联信息:
NutUI Taro 中的 Textarea 组件中使用的是 HTML 标签 textarea,会被 Taro 的插件
@tarojs/plugin-html
转换为小程序原生的 textarea,其中 auto-focus 属性会被映射为 focus这个 PR 是什么类型? (至少选择一个)
这个 PR 涉及以下平台:
这个 PR 是否已自测:
Summary by CodeRabbit
textarea
组件中auto-focus
属性的问题,现在会根据autofocus
的值有条件地设置为true
。