Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(textarea): 修复 slot 嵌套使用 textarea 时的输入失焦问题 #3084

Merged
merged 1 commit into from
May 17, 2024

Conversation

eiinu
Copy link
Member

@eiinu eiinu commented May 17, 2024

这个 PR 做了什么? (简要描述所做更改)

场景:textarea 的使用层级较深(即被多层组件包裹使用)时,输入会触发失去焦点,导致无法连续输入
代码:当 autofoucs 设置为 false 时,上述场景会被触发
解决办法:当 autofocus 为 true 时设置属性,否则不设置

历史提交:
810cb85
#2123

关联信息:
NutUI Taro 中的 Textarea 组件中使用的是 HTML 标签 textarea,会被 Taro 的插件 @tarojs/plugin-html 转换为小程序原生的 textarea,其中 auto-focus 属性会被映射为 focus

这个 PR 是什么类型? (至少选择一个)

  • feat: 新特性提交
  • fix: bug 修复
  • docs: 文档改进
  • style: 组件样式/交互改进
  • type: 类型定义更新
  • perf: 性能、包体积优化
  • refactor: 代码重构、代码风格优化
  • test: 测试用例
  • chore(deps): 依赖升级
  • chore(demo): 演示代码改进
  • chore(locale): 国际化改进
  • chore: 其他改动(是关于什么的改动?)

这个 PR 涉及以下平台:

  • NutUI H5 @nutui/nutui
  • NutUI Taro @nutui/nutui-taro

这个 PR 是否已自测:

Summary by CodeRabbit

  • 修复
    • 修复了 textarea 组件中 auto-focus 属性的问题,现在会根据 autofocus 的值有条件地设置为 true

@eiinu eiinu linked an issue May 17, 2024 that may be closed by this pull request
Copy link

coderabbitai bot commented May 17, 2024

Walkthrough

此次修改主要集中在 src/packages/__VUE/textarea/textarea.taro.vue 文件中,对 auto-focus 属性进行了调整。现在该属性将根据 autofocus 的值有条件地设置为 trueundefined,以便更灵活地控制自动聚焦功能。

Changes

文件路径 修改摘要
src/packages/__VUE/textarea/textarea.taro.vue :auto-focus="autofocus" 修改为 :auto-focus="autofocus ? true : undefined"

🐇✨
代码如诗,变幻无穷,
聚焦随心,灵活自如。
改动虽小,意蕴深长,
未来之路,代码护航。
🌟📜

Warning

Review ran into problems

Problems (1)
  • Git: Failed to clone repository. Please contact CodeRabbit support.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.96%. Comparing base (0c84db1) to head (4837f5b).

Additional details and impacted files
@@            Coverage Diff             @@
##               v4    #3084      +/-   ##
==========================================
- Coverage   83.98%   83.96%   -0.03%     
==========================================
  Files         226      226              
  Lines       22939    22939              
  Branches     2479     2475       -4     
==========================================
- Hits        19266    19260       -6     
- Misses       3655     3661       +6     
  Partials       18       18              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 0c84db1 and 4837f5b.
Files selected for processing (1)
  • src/packages/__VUE/textarea/textarea.taro.vue (1 hunks)
Files skipped from review due to trivial changes (1)
  • src/packages/__VUE/textarea/textarea.taro.vue

@eiinu eiinu changed the title fix(textarea): 修复 form 多级嵌套 textarea 时的输入失焦问题 fix(textarea): 修复 slot 嵌套使用 textarea 时的输入失焦问题 May 17, 2024
@eiinu eiinu merged commit 2a00413 into jdf2e:v4 May 17, 2024
5 of 6 checks passed
@eiinu eiinu deleted the fix-textarea branch May 17, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment