-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(range): 修复使用 step 时未考虑 min 值的处理 #3111
Conversation
Walkthrough这次变更主要调整了 Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- src/packages/__VUE/range/index.taro.vue (1 hunks)
Additional comments not posted (1)
src/packages/__VUE/range/index.taro.vue (1)
275-275
: 修复了不考虑最小值的问题。此改动现在在计算步长时考虑了最小值
min
,这是一个合理的修复,因为它确保了组件在设置了最小值时能正确地计算出结果。
related issue: #3097 此 PR 修复了当设置步长时,点击刻度计算后的值并不会依据 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v4 #3111 +/- ##
==========================================
- Coverage 83.98% 83.92% -0.06%
==========================================
Files 226 226
Lines 22939 22939
Branches 2478 2474 -4
==========================================
- Hits 19265 19252 -13
- Misses 3656 3669 +13
Partials 18 18 ☔ View full report in Codecov by Sentry. |
这个 PR 做了什么? (简要描述所做更改)
这个 PR 是什么类型? (至少选择一个)
这个 PR 涉及以下平台:
这个 PR 是否已自测:
Summary by CodeRabbit