Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mj-class ignored #164

Closed
abstractcoder opened this issue May 26, 2021 · 1 comment · Fixed by #165
Closed

mj-class ignored #164

abstractcoder opened this issue May 26, 2021 · 1 comment · Fixed by #165
Assignees

Comments

@abstractcoder
Copy link

When running the following example with the latest version of MRML the mj-class elements seem to be ignored https://github.com/jdrouet/mrml/blob/main/resources/compare/success/mj-attributes.mjml

I was attempting to upgrade from v0.3.0 to v1.2.2 when I noticed the issue.

<mjml>
  <mj-head>
    <mj-attributes>
      <mj-text padding="0" />
      <mj-class name="blue" color="blue" />
      <mj-class name="big" font-size="20px" />
      <mj-all font-family="Arial" />
    </mj-attributes>
  </mj-head>
  <mj-body>
    <mj-section>
      <mj-column>
        <mj-text mj-class="blue big">
          Hello World!
        </mj-text>
      </mj-column>
    </mj-section>
  </mj-body>
</mjml>

Expected Result

<td align="left" style="font-size:0px;padding:0;word-break:break-word;">
  <div style="font-family:Arial;font-size:20px;line-height:1;text-align:left;color:blue;">Hello World!</div>
</td>

Actual Result

<td align="left" style="font-size:0px;padding:0;word-break:break-word;">
  <div style="font-family:Arial;font-size:13px;line-height:1;text-align:left;color:#000000;">Hello World!</div>
</td>
@jdrouet
Copy link
Owner

jdrouet commented May 27, 2021

@abstractcoder with [email protected] the bug is now fixed 😉

Thank you very much for the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants