Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mrml-core): read attributes from mj-attributes > mj-class #165

Merged
merged 1 commit into from
May 27, 2021

Conversation

jdrouet
Copy link
Owner

@jdrouet jdrouet commented May 27, 2021

Signed-off-by: Jérémie Drouet [email protected]

Fixes #164

@codecov
Copy link

codecov bot commented May 27, 2021

Codecov Report

Merging #165 (3eb0b5c) into main (3ee20f9) will increase coverage by 0.48%.
The diff coverage is 84.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #165      +/-   ##
==========================================
+ Coverage   87.24%   87.73%   +0.48%     
==========================================
  Files         178      178              
  Lines        5534     5551      +17     
==========================================
+ Hits         4828     4870      +42     
+ Misses        706      681      -25     
Impacted Files Coverage Δ
packages/mrml-core/src/prelude/render.rs 82.92% <70.00%> (+2.40%) ⬆️
...ackages/mrml-core/src/mj_attributes_class/parse.rs 94.44% <100.00%> (ø)
packages/mrml-core/src/mj_head/render.rs 87.23% <100.00%> (+13.20%) ⬆️
packages/mrml-core/src/mjml/print.rs 71.42% <0.00%> (-9.53%) ⬇️
...ckages/mrml-core/src/mj_accordion_element/print.rs 60.00% <0.00%> (-8.00%) ⬇️
packages/mrml-core/src/node/print.rs 78.57% <0.00%> (-3.58%) ⬇️
packages/mrml-core/src/macros.rs 95.74% <0.00%> (-2.13%) ⬇️
packages/mrml-core/src/mj_divider/render.rs 90.58% <0.00%> (-1.18%) ⬇️
packages/mrml-core/src/mj_hero/render.rs 88.97% <0.00%> (-0.41%) ⬇️
packages/mrml-core/src/mj_section/render.rs 86.76% <0.00%> (-0.29%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ee20f9...3eb0b5c. Read the comment docs.

@jdrouet jdrouet merged commit 2649ded into main May 27, 2021
@jdrouet jdrouet deleted the feat-mj-class branch May 27, 2021 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mj-class ignored
1 participant