Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mjml-core): remove randomness when generating component ids #308

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

jdrouet
Copy link
Owner

@jdrouet jdrouet commented Jul 24, 2023

No description provided.

@jdrouet jdrouet enabled auto-merge (squash) July 24, 2023 07:46
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #308 (9610fdc) into main (7663ce5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #308   +/-   ##
=======================================
  Coverage   92.84%   92.84%           
=======================================
  Files         219      218    -1     
  Lines       11790    11795    +5     
=======================================
+ Hits        10946    10951    +5     
  Misses        844      844           
Impacted Files Coverage Δ
packages/mrml-core/lib/css-compare/src/lib.rs 84.14% <100.00%> (ø)
packages/mrml-core/src/mj_carousel/render.rs 96.92% <100.00%> (+<0.01%) ⬆️
packages/mrml-core/src/mj_navbar/render.rs 96.33% <100.00%> (+0.01%) ⬆️
packages/mrml-core/src/prelude/render.rs 92.46% <100.00%> (+0.35%) ⬆️

@jdrouet jdrouet disabled auto-merge July 24, 2023 07:50
@jdrouet jdrouet merged commit 649fe6c into main Jul 24, 2023
7 checks passed
@jdrouet jdrouet deleted the remove-random branch July 24, 2023 07:50
@github-actions github-actions bot mentioned this pull request Oct 7, 2023
@jdrouet jdrouet mentioned this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant