fix: mise trust works incorrectly with symlinked configuration file #2186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have a general feeling of disgust towards this part of the code. I think a lot of decisions have been made (mostly by me of course) around canonicalizing and not canonicalizing that have ramifications that cause behavior to act in particular ways I can't recall when reading and I would need to do a deep dive here to really understand it again. Maybe symlinks just aren't a great way to handle this? Maybe toml files with canonical/non-canonical paths would make things more clear? Idk what we should so but it just gives me a feeling this logic should be rethought from the ground-up at some point. |
|
@jdx After digging a bit around the code to resolve this issue, i can only agree on the sentiment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2175.