feat: implement a few tera functions for mise toml config #2561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Functions: - arch - num_cpus - os - os_family - invocation_directory - quote - kebabcase - lowercamelcase - shoutykebabcase - shoutysnakecase - snakecase - uppercamelcase
erickguan
changed the title
jdx
reviewed
Sep 11, 2024
| .render_str("{{ os_family() }}", &Context::default()) | ||
| .unwrap(); | ||
|
|
||
| assert_eq!("Linux", result); |
There was a problem hiding this comment.
already merged this, but it probably could've been DRYed up with if cfg!() macros
This was referenced Sep 11, 2024
triarius
pushed a commit
to triarius/mise
that referenced
this pull request
Sep 18, 2024
* Add platform-info to get platform information * Add num_cpus to get the number of CPU information * Implement customized tera functions for toml config Functions: - arch - num_cpus - os - os_family - invocation_directory - quote - kebabcase - lowercamelcase - shoutykebabcase - shoutysnakecase - snakecase - uppercamelcase * fixup! Implement customized tera functions for toml config * fixup! Implement customized tera functions for toml config --------- Co-authored-by: Erick Guan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented these functions:
Since there are difference from
just, I figure it's good to check in before I continue implementing more and add documentation.PlatformInfoprovides "runtime" information asuname.justreturnstargetinformation. I don't agree on correctness since it will break if you cross-compile. It's always a hassle for package managers. SoPlatformInfoAPI provides a different output thanjust's.I took inspiration from YADM's template design. I provide the result of
arch,os, ... as is. This behavior aligns withdirenvwheredirenvexposes no arch information. It'sdirenv's users job to parse platform information. And for mise, users can use tera filter to transform text.What do you think of this?
invocation_directoryis annoying to fix.BASE_CONTEXTis initialized lazily so I have difficulty testing other functions (I wrote one test per one custom function). We can come back to this later or refactor the context a bit. I prefer skipping inconsistency for now.justimplements functions likekebabcaseas function. I implement them as tera filters. Any objections?Part of #2049