Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable Java core plugin on Windows #2684

Merged
merged 3 commits into from
Sep 29, 2024
Merged

feat: enable Java core plugin on Windows #2684

merged 3 commits into from
Sep 29, 2024

Conversation

TobiX
Copy link
Contributor

@TobiX TobiX commented Sep 29, 2024

I have no idea what I'm doing, but this looked easy enough :D

It seems the Windows downloads for JDKs are ZIP instead of tar.gz, so I just
switched out the filter and the uncompress step and everything started working
nicely.

Copy link
Contributor

@roele roele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Something unrelated that caught my eye is that the musl feature is probably only relevant in context of (Alpine) Linux. We could also put that behind a unix config.

@jdx jdx enabled auto-merge (squash) September 29, 2024 17:49
@jdx jdx merged commit e4e4b35 into jdx:main Sep 29, 2024
11 checks passed
@TobiX TobiX deleted the windows-java branch September 29, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants