Updated check_shapes() to return updated variables l_x, α, l_y, β #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes made to l_x, α, l_y, β were not propagated back to the original variables leading to hard to catch RunTimeErrors.
|
Hi @RaghuSpaceRajan , That's a good catch! Thanks again, |
|
Hi @jeanfeydy, Thanks a lot for merging in the pull request! No worries about the delay, I know how it is in research - I haven't gotten around to working on using Optimal Transport related ideas in my work in the last year either because I've become busy with other projects in the meantime. Hope I get to use your work soon! Best regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made to l_x, α, l_y, β were not propagated back to the original variables leading to hard to catch RunTimeErrors.