remove the TODO and add resolved condition for HiveTable

jeanlyn · May 10, 2015 · f87ace6 · f87ace6
1 parent a8260e8
commit f87ace6
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala b/sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala
@@ -64,10 +64,11 @@ case class CreateTableAsSelect(
 
   override def output: Seq[Attribute] = Seq.empty[Attribute]
   override lazy val resolved: Boolean =
-    // TODO add more condition?
     tableDesc.specifiedDatabase.isDefined &&
     tableDesc.schema.size > 0 &&
     tableDesc.serde.isDefined &&
+    tableDesc.inputFormat.isDefined &&
+    tableDesc.outputFormat.isDefined &&
     childrenResolved
 }
 
@@ -254,7 +255,6 @@ private[hive] object HiveQl {
 
   /**
    * Returns the HiveConf
-   * TODO get it from HiveContext?
    */
   private[this] def hiveConf(): HiveConf = {
     val ss = SessionState.get() // SessionState is lazy initializaion, it can be null here