Always download full pages. #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When non-full page is given, the last page is repeated.
|
Oh, that might fix the issues I had with DirtyJTAG on ST-Link. Why do you memset to 0xFF rather than 0 (just a curiosity)? Anyway, thanks for the PR! |
|
Wow, that was fast. STM32F1 erases the memory to 0xff. By keeping unused space at 0xff, memory outside the range is not touched. |
|
That makes sense, thanks for the explanation! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When non-full page is given, the last page is repeated. This will inhibit BMP to start.