Remove uncontrolled panics #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Thanks for following up with a PR. I have not been working with Rust at all for some years and this lib has suffered from lack of attention. If you're interested in helping out further, the most pressing item is: #209 |
jeaye
added a commit
that referenced
this pull request
Mar 30, 2024
This is a major version bump due to a couple of breaking changes made to the API. Firstly, the lib itself will no longer panic and will leave any unwrapping or expecting to API consumers. #215 Secondly, a security issue related to `instr` and format strings has been resolved by not only removing `instr` and `mvinstr`, but by removing string formatting within the lib entirely, for functions such as `printw`. Format using your normal Rust mechanisms first and just give it the final string. We always rely on `"%s"` internally now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Libraries shouldn't panic.
This is to fix #214