Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #336

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Update README.md #336

merged 2 commits into from
Aug 30, 2023

Conversation

wellloy1
Copy link
Contributor

Fixed a mistake. "}" is accidentally missed. The example with that mistake will not work.

@wellloy1
Copy link
Contributor Author

Fixed a mistake. "}" is accidentally missed. The example with that mistake will not work.

@coveralls
Copy link

coveralls commented Aug 30, 2023

Coverage Status

coverage: 100.0%. remained the same when pulling 8e6db17 on wellloy1:patch-1 into cca2930 on jeffijoe:master.

README.md Outdated
// instead of guessing. If omitted, will inspect the
// module to determine what to register as.
register: awilix.asClass
// We can give these auto-loaded modules
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed the indentation is off now; let's change line 552 instead from ) to })

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. But it will be line 551, as I see now.

Changed my fix
@jeffijoe jeffijoe merged commit a509623 into jeffijoe:master Aug 30, 2023
4 checks passed
@jeffijoe
Copy link
Owner

Thank you @wellloy1 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants