Include symbols in package #76
Conversation
Fixes http://work.azdo.io/917288, fixes AB#917288
|
Heya @jeffkl how quickly can we get an updated nuget package so we can bump the dep and trigger a new build + insertion round? |
|
Would it be better to push a symbol package or use SourceLink? I thought it was a bad practice to include PDBs in NUPKGs? |
|
Not really. SourceLink is orthogonal to including the PDB. What's sort of considered "bad" practice, AFAIK, is to actually embed the PDB in the DLL, since it might be used in a resource-constrained device (i.e. via Xamarin) and cause unnecessary memory consumption. However, this is not the case here. Finally, for the purposes of VS insertion symbol check, the only thing that would make it green is if in the process of publishing this package, you also uploaded to that symbol server, which I think is way overkill. |
|
I'm not 100% convinced this is correct but I'd rather unblock you. Is Microsoft shipping this library? |
|
Package is pushed, awaiting validation: https://www.nuget.org/packages/Microsoft.Dism/2.0.16 |
|
It seems we're using it as part of our Xamarin Android Device Manager. @garuma would know what for :) |
|
Cool, bumped our dep, on track for insertion! Thanks a lot @jeffkl 💯 |
|
No problem, thanks for the contribution |
Given that the new portable PDBs generated for NS projects are really small for the added benefit of useful stacktraces on errors, it would complement the sourcelink that's already in place. In particular, for VS extensions that use this package, including symbols in the package makes it easier for crash dumps to contain useful stacktraces. i.e. see jeffkl/ManagedDism#76 This would fix bug http://work.azdo.io/971173 too :)
Given that the new portable PDBs generated for NS projects are really small for the added benefit of useful stacktraces on errors, it would complement the sourcelink that's already in place. In particular, for VS extensions that use this package, including symbols in the package makes it easier for crash dumps to contain useful stacktraces. i.e. see jeffkl/ManagedDism#76 This would fix bug http://work.azdo.io/971173 too :)
Given that the new portable PDBs generated for NS projects are really small for the added benefit of useful stacktraces on errors, it would complement the sourcelink that's already in place. In particular, for VS extensions that use this package, including symbols in the package makes it easier for crash dumps to contain useful stacktraces. i.e. see jeffkl/ManagedDism#76 This would fix bug http://work.azdo.io/971173 too :)
Fixes http://work.azdo.io/917288, fixes AB#917288