Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install missing Python package #55

Closed
wants to merge 1 commit into from

Conversation

antoyo
Copy link

@antoyo antoyo commented Dec 4, 2022

Copy link
Owner

@jeffreytse jeffreytse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @antoyo

Thanks for your contribution. This project has provided an option called pre_build_commands to add extra packages.

# Use GitHub Deploy Action to build and deploy to Github
      - uses: jeffreytse/[email protected]
        with:
            ...
            pre_build_commands: 'pacman -S --noconfirm python'        # Add extra packages for your deployment

Thanks & Regards

@antoyo
Copy link
Author

antoyo commented Dec 5, 2022

Oh, sorry, I should have been clearer.
It seems that jekyll-deploy-action now requires the python package, possibly due to an update to pygments.rb.

@jeffreytse
Copy link
Owner

Hi @antoyo

I think that's because you are using the pygments in your projects, just simply adding the pre_build_commands can settle your issue. : )

Thanks & Regards

@antoyo
Copy link
Author

antoyo commented Dec 5, 2022

Alright. If you prefer to not always install packages that are needed for optional dependencies, please close this PR.

@jeffreytse
Copy link
Owner

Hi, as other people may not need the python environment, for time saving, we need to reduce all steps which are unnecessary.

@antoyo antoyo closed this Dec 5, 2022
sangwoo-joh added a commit to sangwoo-joh/book that referenced this pull request Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants