Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop unused/deprecated dependency on cql package #4

Closed
bschoening opened this issue Dec 24, 2021 · 5 comments
Closed

Drop unused/deprecated dependency on cql package #4

bschoening opened this issue Dec 24, 2021 · 5 comments

Comments

@bschoening
Copy link
Collaborator

bschoening commented Dec 24, 2021

I noticed the dependencies in setup.py include both 'cql' and 'cassandra-driver'. Probably only the later is needed.

The cql package (https://pypi.org/project/cql/1.4.0) is deprecated on their own project page at cassndra-dbapi2 and doesn't work with python 3:

https://code.google.com/archive/a/apache-extras.org/p/cassandra-dbapi2
Python DB-API 2.0 client interface for Cassandra [DEPRECATED]

A DB-API 2.0 compliant client library for Cassandra/CQL

This driver has been deprecated. Please use python-driver https://github.com/datastax/python-driver instead.
@jeffwidman
Copy link
Owner

jeffwidman commented Jan 8, 2022

Hmm, good question.

I think this is included because of https://github.com/apache/cassandra/blob/cassandra-4.0.0/pylib/requirements.txt

Is it not actually used in the non-test code anymore? Please confirm that it's only used in the cqlsh test code before we remove here... And honestly, it may not be used even in tests anymore, in which case it'd be nice to submit a PR upstream against Cassandra itself to drop this requirement... then it'd be super clear that we should drop it here.

@bschoening
Copy link
Collaborator Author

Good point, I've created a Jira https://issues.apache.org/jira/browse/CASSANDRA-17247 for this.

If you grep for 'import' you'll observe they aren't used.

@jeffwidman
Copy link
Owner

Two things:

  1. Thanks for opening the JIRA. I saw you attached a patch to the JIRA. In the past when I've opened JIRA's against the Cassandra project, I've also opened PR's against their github repo: https://github.com/apache/cassandra. That seemed to make it easier for them to merge, as I could simply nudge the PR's every so often to get visibility, plus it was easy for them to leave review comments compared to managing a patch attachment. So you might get more traction that route.
  2. Given that the JIRA is open plus this import isn't used in the portion of the code that we ship, I agree we should drop that dep from there. That'd make life simpler for anyone doing pip install cqlsh as one less dep for them. Would you be interested in opening a PR for that?

@jeffwidman
Copy link
Owner

jeffwidman commented Jan 10, 2022

Also FYI @bschoening if you use backticks(``) rather than single quotes(''), github markdown will format the enclosed section as code. Example: 'cqlsh' vs cqlsh

@jeffwidman jeffwidman changed the title Deprecated dependency Drop unused/deprecated dependency on cql package Jan 10, 2022
@jeffwidman jeffwidman mentioned this issue Jan 10, 2022
jeffwidman pushed a commit that referenced this issue Jan 10, 2022
This was an old (2012) python driver for CQL which has been replaced by the DataStax cassandra-driver.

See https://pypi.org/project/cql and https://code.google.com/archive/a/apache-extras.org/p/cassandra-dbapi2
#4
@jeffwidman
Copy link
Owner

Fixed by #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants