Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to set ffmpeg path via environment variable #8

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lesservehicle
Copy link

Hi! I just ran into an issue on macOS, running this with a Homebrew installed version of ffmpeg. The function as-is assumes that the shell is aware of the location of ffmpeg via $PATH, but depending on how you execute the node, your path may be wiped out. I've seen other nodes use this sort of method as a workaround to that.

@hesa2020
Copy link

Just a note "/usr/bin/ffmpeg" wont work on windows.
I would say keep "ffmpeg" and let the user fix his own pathing by modifying environment variable correctly?

If it gets remove from $PATH you are not setting it up correctly.

As a note if you export PATH in a console it will be temporary in that console window until closed but if you edit the path file /etc/paths it should be permanent.

@jeffy5
Copy link
Owner

jeffy5 commented Aug 22, 2024

Thanks for your contribution. Yes, I think @hesa2020 is right. Maybe you should keep the default path as "ffmpeg" so that it works better on all platforms.

@lesservehicle Please change "/usr/bin/ffmpeg" to "ffmpeg". Then I will merge it, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants