Make github.com repo URLs always https #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In developement mode (the default) github.com repo URLs are http, making sites using edit-link-tag have slightly different builds in development than on github pages (dotcom) which are also slightly harder to test for all links being https, eg using html-proofer with its enforce_https option, and making builds published to non-github pages hosts have non-https links to github.com. Trivial patch for a very mild annoyance. The added test is somewhat contrived, because existing tests don't trigger the behavior, running in test mode (which defaults scheme to ssl), or hardcoding the repository url (in the edit-link-tag test).
parkr
approved these changes
Nov 7, 2018
|
@jekyllbot: merge +bug |
jekyllbot
added a commit
that referenced
this pull request
Nov 7, 2018
mlinksva
added a commit
to github/pages-gem
that referenced
this pull request
Jan 3, 2019
To get development mode https testing fix for github.com links from jekyll/github-metadata#133
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In development mode (the default) github.com repo URLs are http,
making sites using edit-link-tag have slightly different builds in
development than on github pages (dotcom) which are also slightly
harder to test for all links being https, eg using html-proofer
with its enforce_https option, and making builds published to
non-github pages hosts have non-https links to github.com.
Trivial patch for a very mild annoyance.
The added test is somewhat contrived, because existing tests don't
trigger the behavior, running in test mode (which defaults scheme
to ssl), or hardcoding the repository url (in the edit-link-tag
test).