Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CI settings and use rubocop-jekyll #150

Merged
merged 14 commits into from
Jan 7, 2019
Merged

Update CI settings and use rubocop-jekyll #150

merged 14 commits into from
Jan 7, 2019

Conversation

parkr
Copy link
Member

@parkr parkr commented Jan 2, 2019 •
edited
Loading

Each commit describes the change!

DirtyF
DirtyF reviewed Jan 2, 2019
View reviewed changes
.rubocop.yml Show resolved Hide resolved
DirtyF
DirtyF reviewed Jan 3, 2019
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
ashmaroli
ashmaroli reviewed Jan 3, 2019
View reviewed changes
Copy link
Member

@ashmaroli ashmaroli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like some changes to be made. But I'm leaving it to your judgement..

jekyll-github-metadata.gemspec Outdated Show resolved Hide resolved
jekyll-github-metadata.gemspec Outdated Show resolved Hide resolved
lib/jekyll-github-metadata/pages.rb Show resolved Hide resolved
DirtyF
DirtyF approved these changes Jan 4, 2019
View reviewed changes
Copy link
Member

@DirtyF DirtyF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐚 🎈

ashmaroli
ashmaroli reviewed Jan 4, 2019
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
@ashmaroli
Use whatever Bundler version you've got
454e335
@ashmaroli
Improve Travis configuration
7af638f 
  * remove redundant `os: linux` definition
  * DRY with YAML anchor and alias
  * misc whitespace changes
@ashmaroli
Appease RuboCop
dc65ad8
@parkr
Copy link
Member Author

parkr commented Jan 7, 2019

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 4b8d57a into master Jan 7, 2019
@jekyllbot jekyllbot deleted the update-ci-and-rubocop branch January 7, 2019 01:31
jekyllbot added a commit that referenced this pull request Jan 7, 2019
@jekyllbot
Update history to reflect merge of #150 [ci skip]
f9fbad0
@jekyll jekyll locked and limited conversation to collaborators Jan 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ashmaroli ashmaroli ashmaroli left review comments

@DirtyF DirtyF DirtyF approved these changes

Assignees
No one assigned
Labels
fix frozen-due-to-age internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@parkr @DirtyF @ashmaroli @jekyllbot