Move owner_metadata to an Owner class and add specs #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashmaroli
reviewed
Jan 29, 2019
|
AppVeyor is failing because web mock appears not to be working? |
|
I've restarted the failed jobs. Update: Nope.. that didn't help! |
ashmaroli
reviewed
Jan 29, 2019
ashmaroli
reviewed
Jan 29, 2019
benbalter
approved these changes
Jan 29, 2019
| # If not specified, defaults to the hash key | ||
| # | ||
| # Returns a symbol representing the instance method | ||
| def self.def_hash_delegators(hash, *methods) |
There was a problem hiding this comment.
Since I introduced this, glad to move this to a module in a subsequent PR to DRY things up.
There was a problem hiding this comment.
Not a huge deal to me. This is a little different than the Repository class. 🤷♂️
|
@jekyllbot: merge +minor |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-on from #158 regarding adding tests.
It also splits out the owner_metadata into an Owner class which can be fetched and attributes allowed as needed. ✨
/cc @kenyonj