Restore log level after running tests that modify it. #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All three expected test warnings are present in the console log for the most recent AppVeyor run above: If you run the test suite on the master branch with the same seed ( |
Certain tests in the suite deliberately provoke warnings. * site_github_munger_spec.rb: GitHub Metadata: site.name is set in _config.yml, but many plugins and themes expect site.title to be used instead. * repository_finder_spec.rb: Not Installed: No such file or directory - git However, other tests set the log level to Error, which suppresses warnings: * edit_link_tag_spec.rb * integration_spec.rb Rspec randomizes the order of the tests. If a random seed is chosen that orders the warning tests ahead of the error tests, then the warnings get logged correctly. Example: --seed 41261 However, if the random seed orders either of the error tests ahead of the warning tests, then the warnings get suppressed. Example: --seed 60792 This commit makes the error tests remember the original log level and restore it after they run. Now the warnings will get logged every time. Resolve jekyll/github-metadata jekyll#201
parkr
reviewed
May 29, 2021
parkr
approved these changes
Jul 10, 2021
|
Thank you so much! @jekyllbot: merge +dev |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #201
Certain tests in the suite deliberately provoke warnings.
GitHub Metadata: site.name is set in _config.yml, but many plugins and themes expect site.title to be used instead.Not Installed: No such file or directory - gitHowever, other tests set the log level to Error, which suppresses warnings:
Rspec randomizes the order of the tests. If a random seed is chosen that orders the warning tests ahead of the error tests, then the warnings get logged correctly. Example: --seed 41261
However, if the random seed orders either of the error tests ahead of the warning tests, then the warnings get suppressed. Example: --seed 60792
This commit makes the error tests remember the original log level and restore it after they run. Now the warnings will get logged every time.