Load ENV via dotenv if available #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,4 +1,9 @@ | |||
| require 'octokit' | |||
| begin | |||
| require 'dotenv' | |||
There was a problem hiding this comment.
What do you think about wrapping these two lines (also) in a if Jekyll.env == 'development'?
I believe we'll also need to require 'jekyll' then, which I don't think will cause any problems.
There was a problem hiding this comment.
Sure, sounds good! But i think we should put require 'jekyll' also in the begin block then because it was removed in 80370fc and it's only a development dependency in the gemspec
There was a problem hiding this comment.
The other way may be:
if defined? Jekyll && Jekyll.env == "development"
|
@benbalter Hi, i updated the PR as we discussed. |
|
@parkr what do you think? |
|
@benbalter I THINK GOOOOOOD! |
|
Thanks @Crunch09! 🌷 🐢 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
i didn't know if tests are needed for this because i think they would only test the behavior already tested in the dotenv repository. Also i'm not sure if i should add something to the README about this.