set page.output to empty string instead of nil
#137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbalter
approved these changes
Jan 12, 2017
| @@ -34,6 +34,7 @@ def self.redirect_to(doc, path) | |||
| # Overwrite the default read_yaml method since the file doesn't exist | |||
| def read_yaml(_base, _name, _opts = {}) | |||
| self.content = "" | |||
There was a problem hiding this comment.
Perhaps self.content = self.output = ""?
There was a problem hiding this comment.
Yes, will change it, thank you!
Crunch09
force-pushed
the
empty-output
branch
from
87664c3
to
6dd4e4f
Compare
|
@jekyllbot: merge +minor. |
|
Thanks @Crunch09! Will work to get a release out with this fix as I know it's breaking builds. Thanks for putting this together! 🌮 🦃 🐢 🌴 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output of the redirect page is used to initialize the content and output of the doc. Before this patch this was
nilwhich raised an exception whengsubwas called on it.fixes jekyll/jekyll#5755