Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use @site to maintain compatibility with Jekyll 3.5 #157

Closed
wants to merge 5 commits into from
Closed

Use @site to maintain compatibility with Jekyll 3.5 #157

wants to merge 5 commits into from

Conversation

benbalter
Copy link
Contributor

@benbalter benbalter self-assigned this Jun 19, 2017
ashmaroli
ashmaroli reviewed Jun 19, 2017
View reviewed changes
.travis.yml Outdated
env: GH_PAGES=true
allow_failures:
- env: GH_PAGES=true # Jekyll 2.4 will fail tests
fast_finish: true

rvm:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xtra whitespace here..

@hubot hubot mentioned this pull request Jun 20, 2017
Merged
3 tasks
@kremalicious kremalicious mentioned this pull request Jun 20, 2017
Closed
@antoniocosta
Copy link

Tested bc16f3f with Jekyll 3.5.
It solves jekyll/jekyll#6154

@benbalter
Copy link
Contributor Author

@ashmaroli can this be closed now that jekyll/jekyll#6163 merged?

@ashmaroli
Copy link
Member

ashmaroli commented Jun 29, 2017 •
edited
Loading

Yes. This is no longer required.
Also confirmed by Pat Hawks

@benbalter benbalter closed this Jun 29, 2017
@benbalter benbalter deleted the jekyll-3-5 branch June 29, 2017 17:44
@jekyll jekyll locked and limited conversation to collaborators Apr 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ashmaroli ashmaroli ashmaroli left review comments

Assignees

@benbalter benbalter

Labels
frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benbalter @antoniocosta @ashmaroli @jekyllbot