iOS tracks

[dairondv1986]

Hi, I recently download the latest code (98edc9e) and the problem is that no tracks are received in javascript Media object. I started debug inside iOS code then i found that the code is commented at line 683 inside getMediaTracks's method, I think it's because of an error when creating the array of tracks. Then I try to fixed then I see the problem was [MLPCastUtilities getTextTrackSubtype:mediaTrack.textSubtype] when textSubtipe is 0 (Unknown) the method getTextTrackSubtype return nil because of default return inside switch. Thanks.

[Lindsay-Needs-Sleep]

Sorry for the slow response, very busy right now (and for the next few months).

Thank you for the bug report and your investigation! This sounds familiar, I do believe I just commented it out because it was causing problems and I didn't have a way to test it.

I don't know much about the tracks, do you know how I can test it?
eg.

• Do the subtitles need to be embed in the video already, or do they come from a separate url?
• Do you have any urls that I can use for testing?

You could try the code from PR #63. There is a good chance it is fixed there.

[dairondv1986]

Hi, sorry for the ultra slow response, very busy too with releases jej, look i just replace the commented code with this one i put next and everything is working fine, at least i receive all tracks send by the chromecast.
for (GCKMediaTrack* mediaTrack in mediaTracks) { NSDictionary* track = @{ @"trackId": @(mediaTrack.identifier), @"customData": mediaTrack.customData == nil? @{} : mediaTrack.customData, @"language": mediaTrack.languageCode == nil? @"" : mediaTrack.languageCode, @"name": mediaTrack.name == nil? @"" : mediaTrack.name, @"subtype": [MLPCastUtilities getTextTrackSubtype:mediaTrack.textSubtype] != nil ? [MLPCastUtilities getTextTrackSubtype:mediaTrack.textSubtype] : @"", @"trackContentId": mediaTrack.contentIdentifier == nil ? @"" : mediaTrack.contentIdentifier, @"trackContentType": mediaTrack.contentType == nil ? @"" : mediaTrack.contentType, @"type": [MLPCastUtilities getTrackType:mediaTrack.type], }; if(track != nil) { [tracks addObject:track]; } }

Sorry i cant share url's for testing but i can test and send to you reports. About the subtitles does not matter if come embed inside the video or come with external urls, I already test it with both of it's working fine.

[Lindsay-Needs-Sleep]

Better late than never! :D

Thank you for the offer to test and the info!

I really would like to be able to include a test for this in the test suite though as well. (To prevent any future error regression).

I understand you can't supply any urls for testing, that's okay, I can try and find a way around that later.

Could you show me a sample of the javascript you use to load media that has tracks (1 for embeded and 1 for external)? (with the urls removed of course) This would help with writing the test!

[dairondv1986]

Hi, I have some problems here to send the subtitles to chromecast, if it's are embedded you don't need to send any info because the chromecast will return every track it reed from mpd. When subtitles are external I use this way: mediaInfo.metadata.tracks.push({ trackContentType: 'text/vtt', trackId: subtitle.source, language: subtitle.lang, }); But if the platform is iOS for some reason the subtitles are not send to chromecast and then I sended like json: if (!this.configService.isAndroid) { mediaInfo.metadata.tracks = JSON.stringify(mediaInfo.metadata.tracks); } this way I have to parse every external subtitle track in the chromecast receiver. If you need more specific tests just let me know.

…

On Mon, Nov 2, 2020 at 1:21 AM Lindsay-Needs-Sleep ***@***.***> wrote: Better late than never! :D Thank you for the offer to test and the info! I really would like to be able to include a test for this in the test suite though as well. (To prevent any future error regression). I understand you can't supply any urls for testing, that's okay, I can try and find a way around that later. Could you show me a sample of the *javascript* you use to load media that has tracks (1 for embeded and 1 for external)? (with the urls removed of course) This would help with writing the test! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#66 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFQILCBH7R2TY4X5X67CR3LSNYXVTANCNFSM4NQ6AH2Q> .

[Lindsay-Needs-Sleep]

Thank you for the sample code!
And for the additional details!