Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix return type in supports fullscreen #4903

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Fix return type in supports fullscreen #4903

merged 2 commits into from
Jul 10, 2024

Conversation

Davoud-Ghargozlou
Copy link
Contributor

Hi
I refactored this issue on SonarCloud

@Davoud-Ghargozlou Davoud-Ghargozlou requested a review from a team as a code owner October 21, 2023 16:32
@sonarcloud
Copy link

sonarcloud bot commented Oct 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@silentTeee
Copy link

I think your commit from #4902 is part of this PR as well. Was that intentional?

@thornbill thornbill added hacktoberfest-accepted cleanup Cleanup of legacy code or code smells labels Nov 3, 2023
@thornbill thornbill added the blocked Requires work on the web client to finish label Nov 29, 2023
@thornbill
Copy link
Member

Tagged as "blocked" since this includes unrelated changes.

@thornbill thornbill force-pushed the refactor-supportsFullscreen branch from e373152 to 09d0b1f Compare June 8, 2024 23:36
@thornbill thornbill added this to the v10.10.0 milestone Jun 8, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.1% Duplication on New Code

See analysis details on SonarCloud

@thornbill @dmitrylyzo
Fix parentheses
8b5119e 
Co-authored-by: Dmitry Lyzo <[email protected]>
@thornbill thornbill removed the blocked Requires work on the web client to finish label Jul 10, 2024
@thornbill thornbill changed the title Refactor supports fullscreen Fix return type in supports fullscreen Jul 10, 2024
@thornbill thornbill merged commit f353a4c into jellyfin:master Jul 10, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitrylyzo dmitrylyzo dmitrylyzo left review comments

@seeplusplus seeplusplus seeplusplus left review comments

@thornbill thornbill thornbill approved these changes

Assignees
No one assigned
Labels
cleanup Cleanup of legacy code or code smells hacktoberfest-accepted
Projects
None yet
Milestone
v10.10.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Davoud-Ghargozlou @silentTeee @thornbill @seeplusplus @dmitrylyzo