Migrate to x-data-grid v7 #5597
Conversation
|
From my understanding, the es-check error comes from the |
In general, this means you need to add that library to the list so that it is compatible with the old devices we are targeting (mostly TVs). But since the Dashboard isn't accessible from TV, perhaps we need to add an exception to ES-check (allow ES6 for the Dashboard). 🤔 |
|
How exactly would adding the library to the list make a difference in compatibility with TVs? Do older TVs not support ES6? Would putting the library in the list whitelist it from checks? |
The listed modules will be transpiled to ES2015.
Yes. The lowest targets are Tizen 2.3 and webOS 1.2. They are from 2015 (old WebKit ~ Chrome 27).
The list I mentioned is for babel-loader, i.e. transpilation. For ES-check, it is Lines 5 to 10 in 2d46211 I think it is safe to exclude Dashboard from ES-check. cc @thornbill |
|
Guess I'll wait for Bill before committing anything then. But is the only option to fix "not": [
"./dist/libraries/pdf.worker.js",
"./dist/libraries/worker-bundle.js",
"./dist/libraries/wasm-gen/libarchive.js",
"./dist/[email protected].*.js",
"./dist/serviceworker.js"
] |
Yeah I agree. We will probably need a separate build of the dashboard to fully realize this, but for this PR we should be good to just ignore the data grid since it isn't used elsewhere. 👍 |
|
All done! Thanks guys for being helpful 👍 |
|
@LittleBigOwI Thanks for the PR! Please don't keep adding merge commits. Unless there is a conflict these just add noise. Thanks again! |
This comment has been minimized.
This comment has been minimized.
|
Migrate to v7.5.1, from 6.19.11
Changes
valueGetterandvalueFormattersignatures as said in the MUI migration docs. MUI docs@mui/x-data-grid/legacysupport. MUI docsFixes. #5524