Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance trickplay #5635

Merged
merged 3 commits into from
Sep 14, 2024
Merged

Enhance trickplay #5635

merged 3 commits into from
Sep 14, 2024

Conversation

Shadowghost
Copy link
Contributor

@Shadowghost Shadowghost commented May 30, 2024 •
edited
Loading

Companion PR to jellyfin/jellyfin#11883

Changes

  • Add new trickplay options to library config and refresh screens

@Shadowghost Shadowghost requested a review from a team as a code owner May 30, 2024 18:41
@Shadowghost Shadowghost mentioned this pull request May 30, 2024
Merged
@thornbill thornbill added this to the v10.10.0 milestone May 30, 2024
@thornbill thornbill added feature New feature or request backend Requires work on the server to finish labels May 30, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

joshjryan
joshjryan reviewed Jun 25, 2024
View reviewed changes
src/strings/en-us.json Outdated
"LabelExtractTrickplayDuringLibraryScanHelp": "Generate trickplay images when videos are imported during the library scan. Otherwise, they will be extracted during the trickplay images scheduled task. If generation is set to non-blocking this will not affect the time a library scan takes to complete."
"LabelExtractTrickplayDuringLibraryScanHelp": "Generate trickplay images when videos are imported during the library scan. Otherwise, they will be extracted during the trickplay images scheduled task. If generation is set to non-blocking this will not affect the time a library scan takes to complete.",
"LabelSaveTrickplayLocally": "Save trickplay images next to media",
"LabelSaveTrickplayLocallyHelp": "Saving trickplay images into media folders will put them next to your media for easy migration and access.",
Copy link

@joshjryan joshjryan Jun 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be nice for this message to state what happens if this checkbox isn't checked...Maybe:
"LabelSaveTrickplayLocallyHelp": "Saving trickplay images into media folders will put them next to your media for easy migration and access. If unchecked, trickplay images will be saved to '/config/metadata/library'."?

@soultaco83
Copy link

@Shadowghost It appears that your src/components/refreshdialog/refreshdialog.js is no longer valid. Line 5 of
import globalize from '../../scipts/globalize';
no longer works and fails to build. Changing it to the following seems to resolve it
import globalize from '../../lib/globalize';

same thing with the file src/components/libraryoptionseditor/libraryoptionseditor.js on line 8

@nielsvanvelzen nielsvanvelzen removed the backend Requires work on the server to finish label Sep 9, 2024
@dmitrylyzo
Copy link
Contributor

It appears that your src/components/refreshdialog/refreshdialog.js is no longer valid. Line 5 of import globalize from '../../scipts/globalize'; no longer works and fails to build. Changing it to the following seems to resolve it import globalize from '../../lib/globalize';

same thing with the file src/components/libraryoptionseditor/libraryoptionseditor.js on line 8

These lines are not changed in this PR and will be updated automatically when the PR is merged to the master.

dmitrylyzo
dmitrylyzo reviewed Sep 9, 2024
View reviewed changes
src/components/refreshdialog/refreshdialog.js Outdated Show resolved Hide resolved
src/strings/en-us.json Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@jellyfin-bot
Copy link
Collaborator

Cloudflare Pages deployment

Latest commit 848d2dbc367a84df7447ed35c4f4a9dce7fb81b1
Status ✅ Deployed!
Preview URL https://d72bccc0.jellyfin-web.pages.dev
Type 🔀 Preview

@thornbill thornbill merged commit 5173862 into jellyfin:master Sep 14, 2024
12 checks passed
soultaco83 added a commit to soultaco83/jellyfin-web-requeststab that referenced this pull request Sep 15, 2024
@soultaco83
Merge PR jellyfin#5635 into taco-jellyfin-web
cc0dab0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshjryan joshjryan joshjryan left review comments

@dmitrylyzo dmitrylyzo dmitrylyzo approved these changes

Assignees
No one assigned
Labels
feature New feature or request
Projects
Jellyfin 10.10
Status: Done
Milestone
v10.10.0
Development

Successfully merging this pull request may close these issues.
7 participants
@Shadowghost @soultaco83 @dmitrylyzo @jellyfin-bot @joshjryan @nielsvanvelzen @thornbill