play/pause when Enter is pressed on non-dragging position slider

[shoffing]

Hey there, first time contributor here! Open to any and all feedback.

Changes

Background: This fixes a minor annoyance while using Jellyfin on my LG TV that does not have a play/pause media button on the remote (only an "OK" button between the navigation arrows):

Current behavior

Pressing "Enter" on the now playing position slider when it is not being dragged does nothing. This means resuming playback after scrubbing the position slider requires 4 inputs every time to manually click the OSD Play button: Down -> Right -> Right -> OK

New behavior

Pressing "Enter" on the position slider when it is not being dragged will play/pause the current media. Now resuming playback after scrubbing only requires one remote input: OK

To achieve this, I needed to dispatch a new event "playpause" from the emby-slider component, and listen for that event in the playback/video controller.

Manual testing

I tested these changes manually using LG's simulator.

[dmitrylyzo]

Play/pause should not be in the slider - it is a generic element that is not tied to playback. You probably need to catch click (or keydown) event from the slider when it was not processed by the slider.

[dmitrylyzo]

I suggest you not to use your master branch for PRs. Create a separate branch from your current master (it will contain current changes) and open a new PR with the new branch (AFAIK, there's no way to change the source branch of PR).

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[shoffing]

Closed in favor of #5687