Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace existence check with optional chaining #5742

Merged
merged 2 commits into from
Aug 17, 2024

Conversation

prsantos-com
Copy link
Contributor

Changes
Replaced the logical expression that checks for null/undefined with the optional chaining operator (?.) as per sonarcloud rule s6582.

Issues

@prsantos-com prsantos-com requested a review from a team as a code owner June 29, 2024 02:47
@thornbill thornbill added the cleanup Cleanup of legacy code or code smells label Jul 11, 2024
@prsantos-com
Copy link
Contributor Author

Hi, just wondering if I need to do anything more to get this merged, otherwise I'll continue to wait.

@jellyfin-bot jellyfin-bot added the merge conflict Conflicts prevent merging label Aug 16, 2024
@jellyfin-bot

This comment has been minimized.

@jellyfin-bot jellyfin-bot removed the merge conflict Conflicts prevent merging label Aug 17, 2024
Copy link

sonarcloud bot commented Aug 17, 2024

@jellyfin-bot
Copy link
Collaborator

Cloudflare Pages deployment

Latest commit 0b1259b9b93c2525e9b4c5b6a5086670af99bf08
Status ✅ Deployed!
Preview URL https://35f0525a.jellyfin-web.pages.dev
Type 🔀 Preview

@thornbill thornbill added this to the v10.10.0 milestone Aug 17, 2024
@thornbill
Copy link
Member

Hi, just wondering if I need to do anything more to get this merged, otherwise I'll continue to wait.

Hey @prsantos-com, no there isn't anything else that you need to do. I'm just a bit behind on reviews. As long as a PR doesn't have conflicts, I will get to it eventually. If you want to help things move faster, I would welcome your input in the form of reviews on other open PRs.

Thanks for your contribution!

@thornbill thornbill merged commit 1da9b54 into jellyfin:master Aug 17, 2024
12 checks passed
@prsantos-com
Copy link
Contributor Author

Hey @prsantos-com, no there isn't anything else that you need to do. I'm just a bit behind on reviews. As long as a PR doesn't have conflicts, I will get to it eventually. If you want to help things move faster, I would welcome your input in the form of reviews on other open PRs.

Thanks for your contribution!

Hey @thornbill, I would be happy to review other open PRs. Which ones should I review first? Is there a particular way that I should go about doing this? I'm open to reading any guidelines specific to the project regarding PR reviews.

@thornbill
Copy link
Member

I normally use this query to find PRs that are ready for review: https://github.com/jellyfin/jellyfin-web/pulls?q=is%3Apr+draft%3Afalse+-label%3Astale+-label%3A%22merge+conflict%22+-label%3Abackend+-label%3Ablocked+-label%3Aupstream+-label%3Adependencies+is%3Aopen

The main thing would be testing that the changes function as expected and there are not any obvious code errors being introduced. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Cleanup of legacy code or code smells
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants