Add user setting for whether to display ratings in Video Player and Up Next Dialog Window #5774
Conversation
dmitrylyzo
added
enhancement
…p Next Dialog Window
flebel9
force-pushed
the
add-setting-for-rating-playback-and-nextup
branch
from
c0bfc89
to
f2c8398
Compare
src/scripts/settings/userSettings.js
Outdated
| return this.set('enableDisplayRatingsInPlayer', val.toString()); | ||
| } | ||
|
|
||
| return toBoolean(this.get('enableDisplayRatingsInPlayer', false)); |
There was a problem hiding this comment.
Shouldn't we enable it by default to keep the current behavior?
| @@ -146,6 +146,14 @@ <h2 class="sectionTitle"> | |||
| </div> | |||
| </div> | |||
|
|
|||
| <div class="checkboxContainer checkboxContainer-withDescription"> | |||
There was a problem hiding this comment.
I would place it before fldExternalPlayer. When the latter is displayed, the order is odd: NextVideoOverlay, ExternalPlayer, DisplayRatings (for next video overlay).
|
My 2 cents on this; I'm not a fan of yet another setting for an extremely small detail. I do think those ratings are quite useless during playback so personally I'd remove them without a preference. |
@dmitrylyzo Do you have a preferred approach for this? I am happy to continue the change to make this a preference or remove if that is the general opinion. |
|
Ratings have been added in #4491 to close the feature request. We don't visit item details to see rating for the next item, so it looks more useful in the NextUp dialog compared to the main OSD. Since we don't have a clear opinion, I would make it customisable. But I'm not good at UI design. 😅 |
Cloudflare Pages deployment
|
|
I thought about this and it does seem unnecessary to display ratings for the current video when they can be seen by going to the details page for the video in question which is more likely to happen for those who want it. The NextUp dialog looks to be where this should be rather than the main OSD in that case. |
|
I think my vote would be for no options. Remove it from the OSD and keep it in the next up dialog. |
Changes
Adds user setting under Playback section to control whether ratings should be displayed in the Video Player and Up Next Dialog Window.
Image of setting:
Player bar with setting disabled and enabled:
Next up window with setting disabled and enabled: