Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include The Name Of The TV Show while displaying Episodes In Playlists. #5778

Merged
merged 7 commits into from
Sep 3, 2024

Conversation

venkat-karasani
Copy link
Contributor

Changes
While getting the name for the episode to display in playlist, adding the series name if it is getting displayed inside a playlist
Note: Also did the change where the similar naming convention is followed for the episodes when they are displayed in a collection. I will revert this if it is not needed.

Issues
Fixes #5750

@venkat-karasani venkat-karasani requested a review from a team as a code owner July 13, 2024 05:05
@thornbill thornbill added the enhancement Improve existing functionality or small fixes label Jul 26, 2024
@thornbill thornbill added this to the v10.10.0 milestone Jul 26, 2024
@thornbill
Copy link
Member

Could you post a screenshot of what changed (current appearance vs with this change applied)? Thanks!

@venkat-karasani
Copy link
Contributor Author

venkat-karasani commented Jul 27, 2024

Could you post a screenshot of what changed (current appearance vs with this change applied)? Thanks!

Here you go,

Before:
before

After:
after

From the images you can see that the before image does not have the series name and it is not quite useful but the after image has the series name at the beginning of the title and is useful even when we have wide range of things in the playlist.

These changes will also be there for collections. If needed, I will revert the changes related to the display for series name in collection.

Copy link

sonarcloud bot commented Jul 27, 2024

@thornbill
Copy link
Member

It looks like this is already supported if we pass showParentTitle: true here: https://github.com/jellyfin/jellyfin-web/blob/master/src/scripts/playlistViewer.js#L22

Copy link

sonarcloud bot commented Aug 27, 2024

@jellyfin-bot
Copy link
Collaborator

Cloudflare Pages deployment

Latest commit f843cdd66604ece31ff5635ea1772408730b50b0
Status ✅ Deployed!
Preview URL https://d67367ec.jellyfin-web.pages.dev
Type 🔀 Preview

@venkat-karasani
Copy link
Contributor Author

It looks like this is already supported if we pass showParentTitle: true here: https://github.com/jellyfin/jellyfin-web/blob/master/src/scripts/playlistViewer.js#L22

Yes, it seems to be working. This is how it looks with these changes:
image

@thornbill thornbill merged commit 6bee869 into jellyfin:master Sep 3, 2024
12 checks passed
@MovieWiz
Copy link

Should I be seeing this fix in version 10.9.11 which was released about a week after this change?

@thornbill
Copy link
Member

No

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing functionality or small fixes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

TV Show Episodes In Playlists Don't Include The Name Of The Show
4 participants