Prevent modal close on mouse press up if outside the dialog #5781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
venkat-karasani
changed the title
thornbill
force-pushed
the
prevent-modal-close
branch
from
88cf8c2
to
2ed3ace
Compare
|
thornbill
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The dialog is being closed because of the click handler being attached inside the addBackdropOverlay in dialogHelper. As it is being used in multiple places, we cannot disable the adding of these listeners. From now, whenever we want to prevent a dialog to be closed on click or right click, we have to pass an additional options object to the dialog.open method and it should have preventCloseOnClick, preventCloseOnRightClick set to true which will prevent the attaching of the corresponding event listener and there by prevents the closing of dialog on click or right click.
This PR will prevent the closing of edit metadata dialog on both click and right click.
Issues
ex. Fixes #5723