Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add empty password save error message #5904

Merged
merged 7 commits into from
Aug 21, 2024

Conversation

GabrielGavrilov
Copy link
Contributor

@GabrielGavrilov GabrielGavrilov commented Aug 11, 2024

Since administrators aren't allowed to unset their passwords, there should be some sort of toast message.

Currently if an administrator were to try to unset their password, they would get a "Invalid username or password. Please try again." message.

Changes
Whenever an administrator will try to unset their own password, they would get a "New password cannot be empty." message.

Issues
Fixes #5752

@GabrielGavrilov GabrielGavrilov requested a review from a team as a code owner August 11, 2024 04:57
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint doesn't pass. Please fix all ESLint issues.

src/components/dashboard/users/UserPasswordForm.tsx Outdated Show resolved Hide resolved
src/components/dashboard/users/UserPasswordForm.tsx Outdated Show resolved Hide resolved
src/components/dashboard/users/UserPasswordForm.tsx Outdated Show resolved Hide resolved
@thornbill thornbill added the enhancement Improve existing functionality or small fixes label Aug 20, 2024
@thornbill thornbill added this to the v10.10.0 milestone Aug 20, 2024
Copy link

sonarcloud bot commented Aug 20, 2024

@jellyfin-bot
Copy link
Collaborator

Cloudflare Pages deployment

Latest commit a25e29161be0978f1529a4cc9f00ec8a8e71e8dd
Status ✅ Deployed!
Preview URL https://22a97039.jellyfin-web.pages.dev
Type 🔀 Preview

@thornbill thornbill merged commit 302ea0b into jellyfin:master Aug 21, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing functionality or small fixes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Issue]: Admin password cannot be unset, vague error ensues
3 participants