Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default choice to collection display order #5991

Merged
merged 3 commits into from
Sep 29, 2024

Conversation

lostb1t
Copy link
Contributor

@lostb1t lostb1t commented Aug 29, 2024

Implementation of jellyfin/jellyfin#12457

This allows an user to set the display order of an collection to Default.

@lostb1t lostb1t requested a review from a team as a code owner August 29, 2024 07:55
@thornbill
Copy link
Member

Is "Default" the default order now?

@lostb1t
Copy link
Contributor Author

lostb1t commented Sep 4, 2024

No, premieredate is kept as default

@thornbill
Copy link
Member

Let’s use “Date modified” for the label.

@lostb1t
Copy link
Contributor Author

lostb1t commented Sep 28, 2024

@thornbill done

As its a new string, do i need to add translations or is that handled automatic?

@thornbill
Copy link
Member

Just add it for en-us please. Other languages are handled in our weblate instance.

@lostb1t
Copy link
Contributor Author

lostb1t commented Sep 28, 2024

cool, pushed it.

Copy link

sonarcloud bot commented Sep 28, 2024

@jellyfin-bot
Copy link
Collaborator

Cloudflare Pages deployment

Latest commit f7c2a273e3eb6a4a82c6da41afed507d2619db6a
Status ✅ Deployed!
Preview URL https://f97dcd9f.jellyfin-web.pages.dev
Type 🔀 Preview

@thornbill thornbill added the enhancement Improve existing functionality or small fixes label Sep 29, 2024
@thornbill thornbill added this to the v10.10.0 milestone Sep 29, 2024
@thornbill thornbill merged commit 24b413c into jellyfin:master Sep 29, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing functionality or small fixes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants