Fix focus indication on tags, artist and album #6046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrylyzo
added
bug
dmitrylyzo
force-pushed
the
fix-focus
branch
from
a76dc2c
to
2f70015
Compare
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
`emby-button` class is used as a flag for `EmbyButton.createdCallback`.
`emby-button` class is used as a flag for `EmbyButton.createdCallback`.
dmitrylyzo
force-pushed
the
fix-focus
branch
from
2f70015
to
edfae1f
Compare
|
Cloudflare Pages deployment
|
thornbill
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Remove
emby-buttonclass - it should be added byEmbyButtonon its own.emby-buttonclass is used as a flag forEmbyButton.createdCallback.Issues
Fixes #6045
Notes
This fixes the indication, but the focus breaks on
Backaction because these elements are re-generated.