Separate bitrate control from resolution

[gnattu]

Changes

• Remove all resolution related text from bitrate control as the server does not set resolution based on that. The actual field is kept as I'm unsure if that is used anywhere
• Only keep on entry of bitrate that is higher than original bitrate to allow using source bitrate, hide all other entries as the extremely high ones like 120Mbps is meaningless for 4Mbps source, and such option usually confuses our user.

Issues

A follow up of the server change: jellyfin/jellyfin#12644, but that not depends on that PR, this just works better with that merged.

[github-actions]

ESLint doesn't pass. Please fix all ESLint issues.

[github-actions]

ESLint doesn't pass. Please fix all ESLint issues.

[dmitrylyzo]

Seems to work.

1. Assume we have HEVC/AV1 and have to transcode to H264. The next higher bitrate may not be enough for comparable quality.

2. When we select some bitrate (say 15Mbps) and then start another video with a lower bitrate (say 4Mbps), it puts a checkmark on Auto. It worked the same way before, though. 🤷‍♂️

[gnattu]

When we select some bitrate (say 15Mbps) and then start another video with a lower bitrate (say 4Mbps), it puts a checkmark on Auto. It worked the same way before, though. 🤷‍♂️

I noticed this as well but I decided to leave it the same way as before because it always has been like this for a few years. If we want to change this we need to think about what way is better and change that accordingly which is out of scope of this PR.

Assume we have HEVC/AV1 and have to transcode to H264. The next higher bitrate may not be enough for comparable quality.

Or do we port the scaling function into the web as well and also scale based on that?

[dmitrylyzo]

Or do we port the scaling function into the web as well and also scale based on that?

That would be ideal in terms of math, but it will require them to be synchronized. If only we could add this function to the SDK.

As I see, we were adding bitrates for the next higher resolution. This produces more than 1 extra bitrate.
For simplicity, we can go this way.
Hmm, no - we limit it with the currently selected resolution. But using a second higher bitrate is still an option.

Since we are detaching bitrate from resolution, this becomes unnecessary:

jellyfin-web/src/components/playbackSettings/playbackSettings.js

Lines 280 to 308 in e5df4dd

	function setSelectValue(select, value, defaultValue) {
	select.value = value;
	if (select.selectedIndex < 0) {
	select.value = defaultValue;
	}
	}
	function onMaxVideoWidthChange(e) {
	const context = this.options.element;
	const selectVideoInNetworkQuality = context.querySelector('.selectVideoInNetworkQuality');
	const selectVideoInternetQuality = context.querySelector('.selectVideoInternetQuality');
	const selectChromecastVideoQuality = context.querySelector('.selectChromecastVideoQuality');
	const selectVideoInNetworkQualityValue = selectVideoInNetworkQuality.value;
	const selectVideoInternetQualityValue = selectVideoInternetQuality.value;
	const selectChromecastVideoQualityValue = selectChromecastVideoQuality.value;
	const maxVideoWidth = parseInt(e.target.value || '0', 10) || 0;
	fillQuality(selectVideoInNetworkQuality, true, 'Video', maxVideoWidth);
	fillQuality(selectVideoInternetQuality, false, 'Video', maxVideoWidth);
	fillChromecastQuality(selectChromecastVideoQuality, maxVideoWidth);
	setSelectValue(selectVideoInNetworkQuality, selectVideoInNetworkQualityValue, '');
	setSelectValue(selectVideoInternetQuality, selectVideoInternetQualityValue, '');
	setSelectValue(selectChromecastVideoQuality, selectChromecastVideoQualityValue, '');
	}

[gnattu]

Hmm, no - we limit it with the currently selected resolution. But using a second higher bitrate is still an option.

As a simplified option we can just display the option that is first higher than 1.5x of the source bitrate when we are doing hevc/av1/vp9 to h264. This is a rough estimate but should work good enough for most of them because it is the estimated compression efficiency in common bitrate range (8-10mbit/s)

[gnattu]

I made the tradeoff option: increase the bitrate used to filter the control options by a factor of 1.5 when it is not too high (below the 20Mbps option). Ideally we only have to do this when transcoding to h264, but unfortunately we need extra api call to get this kind of info and it is not ideal to me. Maybe we can improve the API in future releases but I think this is okay for now.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[jellyfin-bot]

Cloudflare Pages deployment

Latest commit	d9d2f8d0be6ff06cb23dd265441dfed0761b3403
Status	✅ Deployed!
Preview URL	https://e0bc0104.jellyfin-web.pages.dev
Type	🔀 Preview

stale