Make movie's shuffle button use the current filters

[davidmurdoch]

Changes

Updates the random movies button so it chooses a random movie from the filtered list, instead of choosing a random movie from all movies.

Note: I do think this was the original intent of the movie's Shuffle button, as the button is removed from the UI when the applied filters return 0 movies.

Issues
Fixes #3732

[dmitrylyzo]

Could you also rebase your branch onto recent master and force-push?

[davidmurdoch]

Could you also rebase your branch onto recent master and force-push?

Done. Let me know if you need the loading.hide() added in the finally block, too (or feel free to commit and merge to this branch yourself!)

[dmitrylyzo]

Tested it a bit more.
Previously, it randomly played the entire Movie library (not just one random movie).
Shuffle button on the list page seems to be implemented this way:

jellyfin-web/src/controllers/list.js

Lines 775 to 788 in 97d4f94

	function shuffle() {
	const currentItem = self.currentItem;
	if (currentItem && !self.hasFilters) {
	playbackManager.shuffle(currentItem);
	} else {
	getItems(self, self.params, currentItem, 'Random', 0, 300).then(function (result) {
	playbackManager.play({
	items: result.Items,
	autoplay: true
	});
	});
	}
	}

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[davidmurdoch]

@dmitrylyzo I merged your latest suggested changes. Do we still need the finally block added in a previous commit?

[jellyfin-bot]

Cloudflare Pages deployment

Latest commit	ce4aded6545752fb2a34b7cef23b4f62cfb533d8
Status	✅ Deployed!
Preview URL	https://bab52c59.jellyfin-web.pages.dev
Type	🔀 Preview

[dmitrylyzo]

Do we still need the finally block added in a previous commit?

Yes, because isLoading = true is still there and we need to reset it.