Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added option to control how long the screensaver takes to start #6165

Merged
merged 6 commits into from
Oct 9, 2024
Merged

Added option to control how long the screensaver takes to start #6165

merged 6 commits into from
Oct 9, 2024

Conversation

ethanarns
Copy link
Contributor

Changes

  • Added setting in Display Settings for time until screensaver, defaulting to 3 minutes
  • Load the setting from Display Settings to change the time it takes for the screensaver to activate
  • Reduced screensaver check time from 10 seconds to 5 seconds
  • Added English translations for new settings

Issues

@ethanarns ethanarns requested a review from a team as a code owner October 5, 2024 05:15
github-actions[bot]
github-actions bot previously requested changes Oct 5, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint doesn't pass. Please fix all ESLint issues.

src/components/displaySettings/displaySettings.js Outdated Show resolved Hide resolved
src/scripts/screensavermanager.js Outdated Show resolved Hide resolved
dmitrylyzo
dmitrylyzo reviewed Oct 5, 2024
View reviewed changes
src/scripts/screensavermanager.js Outdated Show resolved Hide resolved
src/strings/en-gb.json Outdated Show resolved Hide resolved
src/strings/en-us.json Outdated Show resolved Hide resolved
@dmitrylyzo dmitrylyzo added the enhancement Improve existing functionality or small fixes label Oct 5, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@jellyfin-bot
Copy link
Collaborator

Cloudflare Pages deployment

Latest commit 546872b38c159e788d82a48e7af371ef2c285ad0
Status ✅ Deployed!
Preview URL https://1722416b.jellyfin-web.pages.dev
Type 🔀 Preview

dmitrylyzo
dmitrylyzo approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@dmitrylyzo dmitrylyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe only rebase and squash.

@thornbill thornbill added this to the v10.10.0 milestone Oct 9, 2024
@thornbill thornbill merged commit 0cc2b06 into jellyfin:master Oct 9, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitrylyzo dmitrylyzo dmitrylyzo approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
enhancement Improve existing functionality or small fixes
Projects
Jellyfin 10.10
Status: Done
Milestone
v10.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ethanarns @jellyfin-bot @dmitrylyzo @thornbill