-
-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TV Shows: Document "Specials in Seasons" feature #1107
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add what the settings do? It's not really obvious from the setting names where the specials will play.
Really? I feel like the names are fine, but IMO the order of fields in the Metadata editor is not ideal. "Airs before Episode" (field on the right) can be used in conjunction with "Airs before Season" (field on the left) to insert it somewhere in between. But (at least logically) it can't be used with "Airs after Season" (field in the middle) because.. well, presumably it's always at the end of the season where an "airs before episode" doesn't make sense. I'll try writing something up. edit: I also just noticed you can actually fill all 3 fields, but "after Season" trumps the other 2 regardless of what was first set. Maybe not an ideal workflow (although one could argue that's a user error for inputting nonsensical data, but still). |
67be299
to
7b5528c
Compare
Cloudflare Pages deployment
|
Updated according to the above comments. Should be noted that I documented it how it should work, but there is currently jellyfin/jellyfin-web#6049 where the Season's Play button doesn't behave correctly. |
is this ready for review? |
Sure, I've nothing else to add. The mentioned issue also has a pending PR for a fix so that's not needed anymore either. |
Noticed this wasn't documented anywhere, so added it.