Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Azure DNS API version to 2016-04-01 #24

Closed
wants to merge 2 commits into from

Conversation

justaugustus
Copy link

@justaugustus justaugustus commented Jul 20, 2017

Update Azure DNS API version to 2017-06-01

Ref:

@justaugustus
Copy link
Author

I will open an issue in the Azure TF providers project later today, when I have a chance to grab the debug logs.
In the meantime, @stack72 / @tombuildsstuff , could you take a look here: coreos/tectonic-installer#1315 (comment)

@tombuildsstuff
Copy link
Collaborator

@justaugustus thanks for this - I'll test this and import it into Terraform tomorrow :)

@justaugustus
Copy link
Author

@tombuildsstuff I poked at this again within coreos/tectonic-installer and it appears that the correct version for the DNS API is actually 2016-04-01. I've corrected this on the PR.

Have you had a chance to test around on your end?

@tombuildsstuff tombuildsstuff changed the title Update Azure DNS API version to 2017-06-01 Update Azure DNS API version to 2016-04-01 Jul 24, 2017
@tombuildsstuff
Copy link
Collaborator

Hey @justaugustus

Thanks for the reminder - I'm taking a look at this now :)

Thanks!

@tombuildsstuff
Copy link
Collaborator

An update: from what I can see moving to 2016-04-01 requires a bit more than swapping out the version - for a start the field tags appears to have been renamed to metadata.

I've opened Issue hashicorp/terraform-provider-azurerm#192 to track this - and I'm going to continue with this tomorrow..

T

@justaugustus
Copy link
Author

@tombuildsstuff Thanks for the update!

@tombuildsstuff
Copy link
Collaborator

@justaugustus just to give an update here - I've just finished merging support for the Azure SDK for Go's DNS SDK into Terraform via hashicorp/terraform-provider-azurerm#192 - which we'll be releasing shortly.

Given that, I believe this PR is no longer needed and as such I'm going to close this - however please feel free to reopen it if needed :)

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants