Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add special enum attributes to whitelist. #306

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

eltoder
Copy link
Contributor

@eltoder eltoder commented Feb 25, 2023

Closes #305

  • I have updated the documentation in the README.md file or my changes don't require an update.
  • I have added an entry in CHANGELOG.md.
  • I have added or adapted tests to cover my changes.
  • I have run tox -e fix-style to format my code and checked the result with tox -e style.

@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2023

Codecov Report

Merging #306 (1a1f489) into main (392a742) will increase coverage by 0.00%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #306   +/-   ##
=======================================
  Coverage   98.93%   98.94%           
=======================================
  Files          20       21    +1     
  Lines         660      665    +5     
=======================================
+ Hits          653      658    +5     
  Misses          7        7           
Impacted Files Coverage Δ
vulture/whitelists/enum_whitelist.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jendrikseipp jendrikseipp merged commit e2e84d0 into jendrikseipp:main Feb 27, 2023
@jendrikseipp
Copy link
Owner

Great, thanks!

@eltoder eltoder deleted the feature/enum-whitelist branch February 27, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positives on enum _name_ and _value_ attributes
3 participants