Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

feat(aws-cli) Bump from 1.19 native package to 1.25.4 pip package #112

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

dduportal
Copy link
Contributor

@dduportal dduportal commented Jun 8, 2022

Context: jenkins-infra/kubernetes-management#2403

=> with the May upgrade of the kubernetes go client (latest patches for any kubectl 1.x line, but also helm 3.9.0), the system in charge of delegating authentication to another command line (in this case aws eks get-token <...> as specified in our kubeconfig) had an API model upgrade: it was changed from v1alpha1 to v1beta1.

Changing the API version annotation in the kubeconfig is not enough: the external CLI, such as aws CLI must be recent.

Problem: we are pinned on the 1.19 line when using the alpine package, because we rely on the 3.15 line from the parent jenkins inbound-agent image.

This PR introduces the following changes:

  • Changes the installation method of the aws-cli from "native Alpine package" to "Python Pip package" to make sure that our AWS CLI version is controlled without depending on the parent image
  • Bump the aws CLI version from 1.19.105 to 1.25.4 (latest today, published 20 hours ago), which supports the v1beta1 authentication
  • Add an updatecli manifest which tracks the AWS CLI version, pinned on the "v1" line though (as the v2 does not work on Alpine).

Copy link
Member

@lemeurherve lemeurherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dduportal dduportal added the enhancement New feature or request label Jun 8, 2022
@dduportal dduportal marked this pull request as ready for review June 8, 2022 14:01
@dduportal dduportal merged commit aebe494 into jenkins-infra:main Jun 8, 2022
@dduportal dduportal deleted the feat/aws-cli-pip branch June 8, 2022 14:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants