-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4565] Rewrite/enhance controller-isolation page #4635
[4565] Rewrite/enhance controller-isolation page #4635
Conversation
You should be able to mark this PR as draft to make this even clearer. |
@daniel-beck This is ready for review now. I just saw something I wanted to change so marked it WIP for about an hour while I did that. |
@@ -2,14 +2,13 @@ | |||
sections: | |||
# index - implied overview | |||
|
|||
- access-control | |||
|
|||
# Legacy sections |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Obsolete comment now, I guess, if we're keeping these two pages around? (Why?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I plan to remove the access-control section and replace it by sections about Security Realm /Authentication and another one about Authorization. Just trying to make incremental changes, one smallish PR at a time. Is there a better way for me to go about this? Should you and I have a chat about the changes you want for this chapter? I started out just trying to incorporate some information I learned from you and to make the terminology match what shows on the UI pages but I am happy to do anything you like.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should you and I have a chat about the changes you want for this chapter?
Yep, I think that's a good idea, see Gitter 😃
This content was moved to commit 033a397 so I am closing this PR. |
Implement #4565 .
@daniel-beck @Wadeck @MarkEWaite