-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 2.452.3 changelog and upgrade guide #7398
Add 2.452.3 changelog and upgrade guide #7398
Conversation
Would like a review from @mawinter69 for the description of the build history panel bug fix, though will accept that we merge this even if that review is not available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
content/_data/changelogs/lts.yml
Outdated
authors: | ||
- mawinter69 | ||
message: |- | ||
Show correct build history panel even when a pending parameterized build includes '$' in a parameter value. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That a pending job with a parameter with $
lead to the an error was just one manifestation of the bug. The example with the addInfoBadge
step in the Jira causes this error to appear in the build history widget as well independent of a pending job. And potentially any other place where a symbol is rendered with a tooltip containing a $
could cause problems, we might have just not encountered it yet. And probably there are other strings used in tooltips that could have caused problems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mawinter69. Would it better describe the breadth of the fix if the first line of the description message said:
Show correct build history panel even when a $' character is included in the build history data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe
Show correct build history panel even when a '$' character is included in a tooltip of build history data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Applied as 655053b
Much better description than the original
Would like a review from @mawinter69 for the description of the build history panel bug fix, though will accept that we merge this even if that review is not available.
Changelog screenshot
Upgrade guide screenshot