feat!(ubuntu): Removed all definitions of 'default_jdk' from ubuntu image templates #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayfranco999
force-pushed
the
ubuntu-provisioning-jdk-fix
branch
from
0d57e6e
to
fd155b5
Compare
jayfranco999
changed the title
jayfranco999
changed the title
jayfranco999
commented
Sep 2, 2024
dduportal
requested changes
Sep 2, 2024
jayfranco999
commented
Sep 3, 2024
jayfranco999
commented
Sep 3, 2024
jayfranco999
commented
Sep 3, 2024
dduportal
reviewed
Sep 3, 2024
Signed-off-by: jayfranco999 <[email protected]> fix-up Signed-off-by: jayfranco999 <[email protected]>
Signed-off-by: jayfranco999 <[email protected]>
jayfranco999
force-pushed
the
ubuntu-provisioning-jdk-fix
branch
from
da4b1e7
to
f0a6d0d
Compare
Signed-off-by: jayfranco999 <[email protected]>
Signed-off-by: jayfranco999 <[email protected]>
jayfranco999
changed the title
jayfranco999
commented
Sep 3, 2024
dduportal
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: removing the default_jdk env variable will introduce failure in goss tess harness for windows and might result in build failures.
As per jenkins-infra/helpdesk#4124 (comment) :
Any definition of a 'default JDK' and 'update-alternatives' on the jenkins-infra/packer-images has been removed from the ubuntu-provisioning script. The corresponding goss test patch has also been added to the goss test harness to check installation of maven.