Limit scoring issues contamination #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Anyone able to help get this pull request working? |
alecharp
force-pushed
the
fix/probes-invalid-bypass
branch
from
0130072
to
b321a58
Compare
|
@kirk-fitz yes, I should have a bit more time in a near future. I cannot make any promises tho. |
It is now up to the probes to determine if the SCM is required or not. The ProbeEngine must not prevent probes from beeing executed because the SCM is not set
alecharp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #522.
Testing done
I ran
mvn testlocally with no problem.However, I could not setup my environment to try to reproduce the production issue.
I'll try to spent a few hours when possible to confirm this resolves #522 before merging.
Submitter checklist