Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.452.1 #528

Merged
merged 1 commit into from
Apr 20, 2024
Merged

2.452.1 #528

merged 1 commit into from
Apr 20, 2024

Conversation

NotMyFault
Copy link
Member

No description provided.

@NotMyFault NotMyFault requested a review from a team as a code owner April 20, 2024 15:10
@NotMyFault NotMyFault mentioned this pull request Apr 20, 2024
Closed
44 tasks
@MarkEWaite
Copy link
Contributor

I don't think that we want this change merged to the master branch. We want the stable-2.452 branch to contain these changes but not the master branch. The master branch builds the weekly release as far as I understand it.

@NotMyFault NotMyFault changed the base branch from master to stable-2.452 April 20, 2024 16:02
@NotMyFault
Copy link
Member Author

I don't think that we want this change merged to the master branch. We want the stable-2.452 branch to contain these changes but not the master branch. The master branch builds the weekly release as far as I understand it.

GH doing GH things again, oops

MarkEWaite
MarkEWaite requested changes Apr 20, 2024
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to target correct destination branch

@NotMyFault
Copy link
Member Author

Needs to target correct destination branch

But that has already been fixed?

MarkEWaite
MarkEWaite requested changes Apr 20, 2024
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry that I missed the change of destination branch. You're correct. Thanks for doing that.

I believe that the branch name is stable-2.452 rather than stable-2.452.1

Jenkinsfile.d/core/package Outdated Show resolved Hide resolved
profile.d/stable Outdated Show resolved Hide resolved
@NotMyFault
2.452.1
0147e12 
Signed-off-by: Alexander Brandes <[email protected]>
MarkEWaite
MarkEWaite approved these changes Apr 20, 2024
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MarkEWaite MarkEWaite merged commit e8a1322 into stable-2.452 Apr 20, 2024
2 checks passed
@MarkEWaite MarkEWaite deleted the 2.452.1 branch April 20, 2024 18:07
@NotMyFault
Copy link
Member Author

We should really look into automating these tasks 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NotMyFault @MarkEWaite