Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8s.io/client-go checksum #49

Merged
merged 1 commit into from
Jan 25, 2019
Merged

Conversation

jglick
Copy link
Contributor

@jglick jglick commented Jan 25, 2019

See golang/go#27925 etc. As discussed in #48. @deanesmith

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: jglick

If they are not already assigned, you can assign the PR to them by writing /assign @jglick in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deanesmith deanesmith requested review from deanesmith and removed request for pmuir and rawlingsj January 25, 2019 20:15
@deanesmith
Copy link
Contributor

/approve

@deanesmith deanesmith closed this Jan 25, 2019
@deanesmith deanesmith reopened this Jan 25, 2019
@deanesmith deanesmith merged commit 64acef8 into jenkins-x-apps:master Jan 25, 2019
@jglick
Copy link
Contributor Author

jglick commented Jan 25, 2019

@jglick jglick deleted the checksum branch January 25, 2019 20:21
@deanesmith
Copy link
Contributor

/approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants