Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Kubernetes External Secrets deprecated, replaced by External Secrets Operator #3661

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ned-si
Copy link

@ned-si ned-si commented Oct 13, 2022

Description

The project Kubernetes External Secrets is deprecated and has been replaced by External Secrets Operator. Jenkins X is using the right one, but the documentation was still mentioning the old one. It has been fixed everywhere, except in the blog posts (intentionally).

Fixes # (issue)

Checklist:

  • I have mentioned the appropriate type(scope), as referenced here in the commit message and PR title for the semantic checks to pass.
  • I have signed off the commit, as per instructions mentioned here.
  • Any dependent changes have already been merged.

@sonarcloud
Copy link

sonarcloud bot commented Oct 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jenkins-x-bot
Copy link
Contributor

Hi @ned-si. Thanks for your PR.

I'm waiting for a jenkins-x or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign msvticket
You can assign the PR to them by writing /assign @msvticket in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ankitm123
Copy link
Member

Not yet, it's still a work in progress. I will add a comment here, once it's working.

@ankitm123
Copy link
Member

/hold

@DavidZisky
Copy link

DavidZisky commented Oct 18, 2022

@ankitm123 can you elaborate? What's "still a work in progress"? ESO integration? The PR changes docs that are already live on your website and in their current form refer to the deprecated tool.

@ankitm123
Copy link
Member

@ankitm123 can you elaborate? What's "still a work in progress"? ESO integration? The PR changes docs that are already live on your website and in their current form refer to the deprecated tool.

Jenkins X still uses KES and not ESO. This is still being worked on: jenkins-x-plugins/jx-secret#387
We have only added the helm chart to the version stream, but it's not the default yet: jenkins-x/jx3-versions#3387

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants